Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: export spinner function from utils prompt #293

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: export spinner function from utils prompt #293

wants to merge 5 commits into from

Conversation

m0nch1
Copy link

@m0nch1 m0nch1 commented Apr 16, 2024 •
edited
Loading

🔗 Linked issue

issue: #284

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Use spinner in examples/spinner.ts, prompt.ts

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

note

Result of local run...

capture.mov

@m0nch1 m0nch1 marked this pull request as ready for review April 16, 2024 15:21
@adesombergh
Copy link

Changing the examples does not fix the issue. Running consola.start(), await new Promise((resolve) => setTimeout(resolve, 1000));, consola.success() will still not show an animated spinner as expected.

@m0nch1
Copy link
Author

m0nch1 commented Apr 17, 2024

@adesombergh
In the current implementation, consola.start does not have a spinner function, and the spinner is defined in utils/prompt.ts

And my PR only works with spinner in example, so there is no way to actually import consola and use it...

I think this needs to be implemented so that spinner can work with prompt...

@m0nch1 m0nch1 changed the title fix: spinner examples fix: export spinner function from utils prompt Apr 17, 2024
@m0nch1 m0nch1 force-pushed the fix-284-spinner-examples branch from c2f12ef to c70e46a Compare April 18, 2024 03:38
@m0nch1
Copy link
Author

m0nch1 commented Apr 18, 2024

I tried to make spinner available from utils!

@m0nch1
Copy link
Author

m0nch1 commented May 17, 2024

@atinux @adesombergh
What do you think of this?
I'm sure spinner is not used yet, and maybe it's okay to not support it, once it is!

@m0nch1 m0nch1 force-pushed the fix-284-spinner-examples branch from c70e46a to 64010a3 Compare June 19, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m0nch1 @adesombergh